[PATCH] D75090: [ORC] Align weak definition handling in JITDylib::defineMaterializing() and JITDylib::defineImpl()

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

In D75090#1904569 <https://reviews.llvm.org/D75090#1904569>, @lhames wrote:

> Is the idea here that the call-through stub is emitted as weak, and then replaced by discovery with a strong definition if one is found in time? Or have I misunderstood?


Yes that's the idea. (Though the actual definition found by discovery might be weak itself -- but I don't handle this yet.) I think the cases where I ran into this are actually race conditions in my code, where multiple threads compete for symbol table access. While I will have to revisit this part, I wondered whether it may be worth having an aligned mechanism for both cases. Something like the (1), (2), (3) described above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75090/new/

https://reviews.llvm.org/D75090