[PATCH] D70283: [x86][SLH] Rm liveness check from data invariance check

Zola Bridges via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 12:57:13 PST 2020


zbrid marked an inline comment as done.
zbrid added inline comments.


================
Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:2222
+      if (!isDataInvariant(UseMI) || UseMI.getParent() != MI.getParent() ||
+          isEFLAGSDefLive(UseMI)) {
         return {};
----------------
MaskRay wrote:
> Delete excess parentheses.
Hm, I'm not sure which parentheses you mean. On my scan, I don't see any extras.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70283/new/

https://reviews.llvm.org/D70283





More information about the llvm-commits mailing list