[PATCH] D75627: [PowerPC][AIX] Fix printing of program counter for AIX assembly.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 11:47:58 PST 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCInstPrinter.cpp:422
+ // Branches can take an immediate operand. This is used by the branch
+ // selection pass to print .+8(ELF) or $+8(AIX), an eight byte displacement
+ // from the program counter.
----------------
Suggestion:
```
[ ... ] This is used by the branch selection pass to print, for example, `.+8` (for ELF) or `$+8` (on AIX) to express an eight byte displacement from the program counter.
```
================
Comment at: llvm/test/CodeGen/PowerPC/aix-print-pc.mir:1
+# RUN: llc -x mir -mtriple powerpc-unknown-aix-xcoff --verify-machineinstrs \
+# RUN: -start-before=ppc-branch-select < %s | FileCheck %s
----------------
Is this a case where we can (or should) test for 64-bit now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75627/new/
https://reviews.llvm.org/D75627
More information about the llvm-commits
mailing list