[PATCH] D72068: [IR] Refactor SubclassData

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 11:47:55 PST 2020


dexonsmith added a comment.

In D72068#1905933 <https://reviews.llvm.org/D72068#1905933>, @ekatz wrote:

> In D72068#1889825 <https://reviews.llvm.org/D72068#1889825>, @rnk wrote:
>
> > I'm still basically not in favor of this. If another contributor thinks it's a great idea, I wouldn't go so far as to block this change, but I don't plan to do any further review.
>
>
> Fair enough, I respect your opinion.
>  However, I still think it is a very welcoming change (for the many reasons listed in the "summary"), and I hope other reviewers will see the benefits as I see them, and approve this change.


Given the contention around direction, I would suggest that you seek consensus via an RFC on llvm-dev before pinging the patch any further.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72068/new/

https://reviews.llvm.org/D72068





More information about the llvm-commits mailing list