[PATCH] D75631: [test] Fix reliability of disassemble-functions.test
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 11:47:52 PST 2020
thopre created this revision.
thopre added reviewers: khemant, compnerd, echristo, jhenderson.
Herald added a subscriber: rupprecht.
Herald added a project: LLVM.
Test tools/llvm-objdump/X86/disassemble-functions.test checks option
--disassemble-functions on main by expecting not to see any reference to
foo but the call to foo is sometimes disassembled into "callq <foo>" by
llvm-objdump. This commit changes the implicit-check-not pattern to look
for "foo:" for more reliability.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D75631
Files:
llvm/test/tools/llvm-objdump/X86/disassemble-functions.test
Index: llvm/test/tools/llvm-objdump/X86/disassemble-functions.test
===================================================================
--- llvm/test/tools/llvm-objdump/X86/disassemble-functions.test
+++ llvm/test/tools/llvm-objdump/X86/disassemble-functions.test
@@ -3,7 +3,7 @@
# RUN: yaml2obj -o %t.out %p/Inputs/simple-executable-x86_64.yaml
# RUN: llvm-objdump -d %t.out --disassemble-functions=main \
-# RUN: | FileCheck %s --check-prefix=MAIN --implicit-check-not=foo --implicit-check-not=somedata
+# RUN: | FileCheck %s --check-prefix=MAIN --implicit-check-not=foo: --implicit-check-not=somedata
# RUN: llvm-objdump -d %t.out --disassemble-functions=main,foo \
# RUN: | FileCheck %s --check-prefixes=MAIN,FOO --implicit-check-not=somedata
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75631.248263.patch
Type: text/x-patch
Size: 760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200304/5d52c564/attachment.bin>
More information about the llvm-commits
mailing list