[PATCH] D75484: [mlir][spirv] Add get() method to TargetEnvAttr taking raw values

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked 2 inline comments as done.
antiagainst added inline comments.


================
Comment at: mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h:58
+                           DictionaryAttr limits);
   static TargetEnvAttr get(IntegerAttr version, ArrayAttr extensions,
                            ArrayAttr capabilities, DictionaryAttr limits);
----------------
mravishankar wrote:
> Can we deprecate this one. I dont see a point of that anymore..
It might still be useful when we have extensions already packed as `ArryAttr` from somewhere else. Let's keep it for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75484/new/

https://reviews.llvm.org/D75484