[PATCH] D73078: [VPlan] Use consecutive numbers to print VPValues instead of addresses.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:636
   /// Each recipe prints itself.
   virtual void print(raw_ostream &O, const Twine &Indent) const = 0;
+  virtual void print(raw_ostream &O, const Twine &Indent,
----------------
gilr wrote:
> It seems all derived recipes have the same implementation for this method, i.e. create a SlotTracker and pass it to the actually-printing variant below. Does it still need to be virtual?
Yes, I've made the non slot tracker variant non-virtual and removed it from the subclasses.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanValue.h:128
 
-raw_ostream &operator<<(raw_ostream &OS, const VPValue &V);
+// raw_ostream &operator<<(raw_ostream &OS, const VPValue &V);
 
----------------
gilr wrote:
> Can we retain such API, which generates an ad-hoc SlotTracker for VPInstruction?
Yes, I've brought it back,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73078/new/

https://reviews.llvm.org/D73078