[PATCH] D75424: [MachinePipeliner] Fix a bug in Output Dependency chains
Brendon Cahoon via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 08:24:59 PST 2020
bcahoon accepted this revision.
bcahoon added a comment.
This revision is now accepted and ready to land.
Thanks for the patch! Your suggested change is correct. The original code only "worked" because output dependences are rare. But, I can see that if the DAG is more complicated, and there is a mix of output and order dependences, that the original code would cause problems when computing the MII. If you have a test case, please add one.
Thanks,
Brendon
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75424/new/
https://reviews.llvm.org/D75424
More information about the llvm-commits
mailing list