[PATCH] D73886: [DebugInfo] Refine the condition to detect CIEs.

Wed Mar 4 08:24:52 PST 2020

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

In D73886#1904675 <https://reviews.llvm.org/D73886#1904675>, @ikudrin wrote:

> Ping.
>
> @probinson, do you suggest to change the intended behavior to crash on incorrect input before fixing this issue?

There is a longer-term effort to make parsing more tolerant, but I see that this is existing behavior in handling .debug_frame and you should not be required to fix it before committing this patch.  However, I would appreciate it if you would file a bug about this, mentioning the eh-frame-cie-id.s test, so that the people trying to clean up the parsing behavior can be aware of it.

File that bug and LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73886/new/

https://reviews.llvm.org/D73886