[PATCH] D75126: [AIX] Extend integer arguments to register width when passed in stack memory.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 07:19:53 PST 2020


sfertile added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6808
 
+  if (ValVT.isInteger() && (ValVT.getSizeInBits() > RegVT.getSizeInBits()))
+    report_fatal_error("Unexpected argument exceeds word size.");
----------------
For 32-bit codegen  we legalize i64s by breaking them into 2 i32s. Is i128  handled similarly, or is it a legal type which this error is trying to catch?


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:6809
+  if (ValVT.isInteger() && (ValVT.getSizeInBits() > RegVT.getSizeInBits()))
+    report_fatal_error("Unexpected argument exceeds word size.");
+
----------------
Minor nit: `word size` --> `register size`, and maybe 'argument' --> 'integer argument'.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75126/new/

https://reviews.llvm.org/D75126





More information about the llvm-commits mailing list