[PATCH] D73744: [SCEV] SCEVExpander::isHighCostExpansionHelper(): cost-model min/max (PR44668)

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:2298
+    case scUMinExpr:
+      PairCost = TTI.getOperationCost(Instruction::ICmp, OpType) +
+                 TTI.getOperationCost(Instruction::Select, OpType);
----------------
I'm a bit concerned about getOperationCost not really returning something useful, so how about getCmpSelInstrCost instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73744/new/

https://reviews.llvm.org/D73744