[PATCH] D75595: [AVR][NFC] Use Register instead of unsigned
Dylan McKay via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 04:34:54 PST 2020
dylanmckay marked an inline comment as done.
dylanmckay added inline comments.
================
Comment at: llvm/lib/Target/AVR/AVRRegisterInfo.cpp:99
+static void foldFrameOffset(MachineBasicBlock::iterator &II, int &Offset,
+ Register DstReg) {
MachineInstr &MI = *II;
----------------
Jim wrote:
> dylanmckay wrote:
> > Fix off-by-one space indentation
> This has been formatted by clang-format.
> Do you mean this should look like?
>
> ```
> static void foldFrameOffset(MachineBasicBlock::iterator &II,
> int &Offset, Register DstReg) {
> ```
Nevermind me, I'm not sure why but even though it's using a monospaced font on my machine, the opening `(` and the `R` for `Register DstReg` don't line up on Phabricator.
I did the ultimate test
```
dylan at dylan-pc:/u/a/lib:> echo "static void foldFrameOffset(" | wc -c
29
dylan at dylan-pc:/u/a/lib:> echo " " | wc -c
29
```
You are right, it is lined up perfectly. Carry on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75595/new/
https://reviews.llvm.org/D75595
More information about the llvm-commits
mailing list