[PATCH] D75341: [BFI] Use CallbackVH to notify BFI about deletion of basic blocks

[Daniil Suchkov via Phabricator via llvm-commits]

DaniilSuchkov added a comment.

In D75341#1903988 <https://reviews.llvm.org/D75341#1903988>, @davidxl wrote:

> This looks good, but it does have implications on memory consumption for BFI.  To avoid that, gate the data structure change on #ifndef NDEBUG.


I understand that, but I don't think we can do anything about it. You see, AssertingVH already gates itself in a way that turns it into a pointer wrapper in Release configuration and BFICallbackVH is always required for correctness, since it updates BFI.
Or am I missing something?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75341/new/

https://reviews.llvm.org/D75341