[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 3 20:10:00 PST 2020
SouraVX added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:24
+ getVersion(), getFlags());
+ if (getFlags() == MACRO_DEBUG_LINE_OFFSET)
+ OS << format(", debug_line_offset = 0x%04" PRIx64 "\n",
----------------
ikudrin wrote:
> Please, use a canonical way to check flags.
I had already done that, just a revision is needed. Waiting for more review comments to come, if remaining.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73086/new/
https://reviews.llvm.org/D73086
More information about the llvm-commits
mailing list