[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

Tue Mar 3 18:30:33 PST 2020

tamur marked 2 inline comments as done.
tamur added inline comments.

================
Comment at: llvm/test/tools/llvm-dwp/X86/handle_strx.test:25-29
+Neither llvm-dwp nor llvm-dwarfdump support for dwarf 5 is complete at this point,
+so we will just check that .dwp file exists and has a DW_FORM_strx1 should suffice.
+
+CHECK: DW_AT_producer [DW_FORM_strx1]
+
----------------
dblaikie wrote:
> What sort of incompletenes problems does this test case trip over? What /should/ be tested but isn't because it's broken in other ways?
> 
> It might be that this patch should be held off on until otehr fixes are made so we're not adding code that can't be well tested, etc.
IIRC, dwarfdump had a non-fatal complaint, but they both work fine for this simple test. Still, I don't want to overspecify the output (and I don't want to make the test depend too much on llvm-dwarfdump), so I think just checking that llvm-dwp works correctly and the output has a DW_FORM_strx1 should suffice?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485