[PATCH] D75297: [TypeSize] Allow returning scalable size in implicit conversion to uint64_t

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 17:52:11 PST 2020


efriedma added a comment.

We've found that having the assertion makes it much easier to track down specific callers.  That means we don't get some weird crash/verifier failure/miscompile later on, we can be reasonably sure that we aren't hitting an issue with this if the assertion doesn't trigger, and we accumulate testcases for various codepaths.  So I'd like to try to keep the assertion if possible.

If it's blocking your work on the intrinsics, though, that's worse.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75297/new/

https://reviews.llvm.org/D75297





More information about the llvm-commits mailing list