[PATCH] D75543: [ConstantFolding] Always return something from ConstantFoldConstant

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

Nice cleanup! LGTM



================
Comment at: lib/Transforms/InstCombine/InstCombineShifts.cpp:619
     // If we got a constantexpr back, try to simplify it with TD info.
+    // TODO: This is dubious, IRBuilder<TargetFolder> should already do this.
     if (auto *C = dyn_cast<Constant>(V))
----------------
Maybe this code was written before we were doing folding in IRBuilder?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75543/new/

https://reviews.llvm.org/D75543