[PATCH] D74440: [mlir][SideEffects] Enable specifying side effects directly on the arguments/results of an operation.

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

General structure looks good to me and we can iterate from here, thanks



================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:897
 
-  let arguments = (ins AnyMemRef:$memref, Variadic<Index>:$indices);
+  let arguments = (ins Arg<"the reference to load from", AnyMemRef,
+                           [MemRead]>:$memref,
----------------
One last question about the ordering, what about switching the constraint and the text?

Then we have

AnyMemRef
Arg<AnyMemRef> 
Arg<AnyMemRef, "the reference to load from">
Arg<AnyMemRef, "the reference to load from", [MemRead]>

and it just seems to extend more naturally (and one could have desc be empty to match what we have today implicitly).

Or is there a reason you prefer this ordering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74440/new/

https://reviews.llvm.org/D74440