[PATCH] D75550: [PGO][PGSO] Use IsColdXNthPercentile for sample PGO.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SizeOpts.h:65
   }
-  return !AdapterT::isFunctionHotInCallGraphNthPercentile(
-      PSI->hasSampleProfile() ? PgsoCutoffSampleProf : PgsoCutoffInstrProf,
-      F, PSI, *BFI);
+  if (PSI->hasSampleProfile())
+    return AdapterT::isFunctionColdInCallGraphNthPercentile(PgsoCutoffSampleProf,
----------------
Can you add some comments here about the logic difference?


================
Comment at: llvm/include/llvm/Transforms/Utils/SizeOpts.h:93
   }
-  return !AdapterT::isHotBlockNthPercentile(
-      PSI->hasSampleProfile() ? PgsoCutoffSampleProf : PgsoCutoffInstrProf,
-      BBOrBlockFreq, PSI, BFI);
+  if (PSI->hasSampleProfile())
+    return AdapterT::isColdBlockNthPercentile(PgsoCutoffSampleProf,
----------------
comment here too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75550/new/

https://reviews.llvm.org/D75550