[PATCH] D74738: Revert "[GISel]: Fix incorrect IRTranslation while translating null pointer types"

Tue Mar 3 15:02:38 PST 2020

aemerson added a comment.

Which part of the langref are you referring to?

Anyway, we discussed this internally and this seems slightly better than using inttoptr.

================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/swifterror.ll:62
 ; CHECK: fmov [[CMP:s[0-9]+]], #1.0
-; CHECK: mov x21, xzr
+; CHECK: mov x21, #0
 ; CHECK: bl {{.*}}foo
----------------
Could you fix up the selection for arm64 here so we can maintain the existing codegen?

In AArch64InstructionSelector::earlySelect we handle zero values for G_CONSTANT, and we should extend that to handle p0 types to generate the xzr/wzr register forms.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74738/new/

https://reviews.llvm.org/D74738