[PATCH] D75024: [SCCIterator] Check if a SCC is a natural loop.

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 15:00:35 PST 2020


baziotis abandoned this revision.
baziotis added a comment.

In D75024#1892194 <https://reviews.llvm.org/D75024#1892194>, @baziotis wrote:

> I think that with the news about SCCIterator, the implementation will be something like that:
>
>   bool isSCCNaturalLoop(scc_iterator<Function *> SCCIt) const {
>     Loop *L = getLoopFor((*SCCIt).front());
>     return L != nullptr;
>   }
>
>
> This is basically a hack and I don't know if it makes sense to put it as part of `LoopInfo`. It doesn't do anything internal to `LoopInfo` that the user couldn't know.
>  What do you think?


Abandoning this as I personally don't see any value :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75024/new/

https://reviews.llvm.org/D75024





More information about the llvm-commits mailing list