[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/tools/llvm-dwp/X86/handle_strx.test:6-20
+#include "a.h"
+
+int main() {
+  f1();
+  return 0;
+}
+
----------------
This looks a bit more complicated than it needs to be - you can dwp any two .o files (so you don't need headers, function calls/cross references, etc), or even a single .o file (& a singel one might be sufficient for the purposes of this test case).


================
Comment at: llvm/test/tools/llvm-dwp/X86/handle_strx.test:25-29
+Neither llvm-dwp nor llvm-dwarfdump support for dwarf 5 is complete at this point,
+so we will just check that .dwp file exists and has a DW_FORM_strx1 should suffice.
+
+CHECK: DW_AT_producer [DW_FORM_strx1]
+
----------------
What sort of incompletenes problems does this test case trip over? What /should/ be tested but isn't because it's broken in other ways?

It might be that this patch should be held off on until otehr fixes are made so we're not adding code that can't be well tested, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485