[PATCH] D75559: [MachineVerifier] Remove placement rule exception for debug entry values
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 3 13:14:08 PST 2020
djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/CodeGen/MachineVerifier.cpp:841
FirstTerminator = MI;
- } else if (FirstTerminator && !MI->isDebugEntryValue()) {
+ } else if (FirstTerminator) {
report("Non-terminator instruction after the first terminator", MI);
----------------
I was wondering if we updated this as well, excellent!
================
Comment at: llvm/test/DebugInfo/MIR/AArch64/no-dbg-value-after-terminator.mir:20
+
+ declare void @llvm.dbg.value(metadata, metadata, metadata)
+
----------------
Nice test! It is well reduced.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75559/new/
https://reviews.llvm.org/D75559
More information about the llvm-commits
mailing list