[PATCH] D75500: StructurizeCFG: simplify phi nodes when possible

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 11:57:43 PST 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/StructurizeCFG.cpp:660
     Q.DT = DT;
-    for (size_t i = 0; i < InsertedPhis.size(); ++i) {
-      PHINode *Phi = InsertedPhis[i];
+    for (auto I : AffectedPhis) {
+      auto Phi = dyn_cast_or_null<PHINode>(I);
----------------
I think auto hurts readability here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75500/new/

https://reviews.llvm.org/D75500





More information about the llvm-commits mailing list