[PATCH] D75539: [mlir] Generate CmpFPredicate as an EnumAttr in tablegen

Alex Zinenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 10:15:37 PST 2020


ftynse accepted this revision.
ftynse added a comment.
This revision is now accepted and ready to land.

Nice cleanup, thanks!

I also considered changing the syntax to drop the quotes (we now have enough support to parse a keyword and check if it is one of the allowed options).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75539/new/

https://reviews.llvm.org/D75539





More information about the llvm-commits mailing list