[PATCH] D75206: [MLIR] Add explicit initial values for loop.parallel op.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 09:40:03 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:416
+  if (succeeded(parser.parseOptionalKeyword("init"))) {
+    if (parser.parseOperandList(initVals, -1, OpAsmParser::Delimiter::Paren))
+      return failure();
----------------
nit: Can you please add /*variableName=*/ comments when using constant arguments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75206/new/

https://reviews.llvm.org/D75206





More information about the llvm-commits mailing list