[PATCH] D75468: [MLIR][GPU] Add error checking to loop.parallel to gpu transform.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp:760
   BlockAndValueMapping cloningMap;
+  llvm::DenseMap<int, Value> launchBounds;
   SmallVector<Operation *, 16> worklist;
----------------
Drop the llvm:: here please.


================
Comment at: mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp:809
+  // bounds.
+  for (auto bound : launchBounds)
+    launchOp.setOperand(std::get<0>(bound), std::get<1>(bound));
----------------
nit: Can we use a type instead of auto? It helps with readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75468/new/

https://reviews.llvm.org/D75468