[llvm] 22ed8c4 - [ORC] Remove an out-of-date FIXME

[Lang Hames via llvm-commits]

Author: Lang Hames
Date: 2020-03-03T09:33:37-08:00
New Revision: 22ed8c49949cb8cb6f44ce53cc45b34403da02f1

URL: https://github.com/llvm/llvm-project/commit/22ed8c49949cb8cb6f44ce53cc45b34403da02f1
DIFF: https://github.com/llvm/llvm-project/commit/22ed8c49949cb8cb6f44ce53cc45b34403da02f1.diff

LOG: [ORC] Remove an out-of-date FIXME

Added: 
    

Modified: 
    llvm/lib/ExecutionEngine/Orc/Layer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ExecutionEngine/Orc/Layer.cpp b/llvm/lib/ExecutionEngine/Orc/Layer.cpp
index 63b04a0562bd..2bf27c44f766 100644
--- a/llvm/lib/ExecutionEngine/Orc/Layer.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/Layer.cpp
@@ -200,8 +200,8 @@ void BasicObjectLayerMaterializationUnit::materialize(
 
 void BasicObjectLayerMaterializationUnit::discard(const JITDylib &JD,
                                                   const SymbolStringPtr &Name) {
-  // FIXME: Support object file level discard. This could be done by building a
-  //        filter to pass to the object layer along with the object itself.
+  // This is a no-op for object files: Having removed 'Name' from SymbolFlags
+  // the symbol will be dead-stripped by the JIT linker.
 }
 
 } // End namespace orc.