[PATCH] D75519: [ExpandMemCmp] Properly constant-fold all compares.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 09:06:04 PST 2020


efriedma added a comment.

Given memcmp expansion is running late in the pipeline, do you think we're possibly missing other relevant optimizations on the loads?  LICM, maybe?



================
Comment at: llvm/test/CodeGen/X86/memcmp.ll:425
 ; X64-NEXT:    bswapl %ecx
+; X64-NEXT:    movl (%rsi), %edx
 ; X64-NEXT:    bswapl %edx
----------------
The scheduling here seems to be worse?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75519/new/

https://reviews.llvm.org/D75519





More information about the llvm-commits mailing list