[PATCH] D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`

Benjamin Barenblat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 08:53:06 PST 2020


bbaren updated this revision to Diff 247920.
bbaren added a comment.

Add some more end-of-line checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72360/new/

https://reviews.llvm.org/D72360

Files:
  lld/test/COFF/start-lib.ll
  lld/test/ELF/assignment-archive.s
  lld/test/ELF/lto/linker-script-symbols-assign.ll
  lld/test/ELF/undefined-glob.s


Index: lld/test/ELF/undefined-glob.s
===================================================================
--- lld/test/ELF/undefined-glob.s
+++ lld/test/ELF/undefined-glob.s
@@ -14,7 +14,7 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
 
 # RUN: ld.lld -o %t.exe %t.o %t.a
-# RUN: llvm-readobj --symbols %t.exe | FileCheck --check-prefix=NO-OPT %s
+# RUN: llvm-nm %t.exe | FileCheck --check-prefix=NO-OPT %s
 
 # NO-OPT-NOT: foo
 # NO-OPT-NOT: bar
Index: lld/test/ELF/lto/linker-script-symbols-assign.ll
===================================================================
--- lld/test/ELF/lto/linker-script-symbols-assign.ll
+++ lld/test/ELF/lto/linker-script-symbols-assign.ll
@@ -3,7 +3,7 @@
 
 ; RUN: echo "foo = 1;" > %t.script
 ; RUN: ld.lld %t.o -o %t2 --script %t.script -save-temps
-; RUN: llvm-readobj --symbols %t2.lto.o | FileCheck %s
+; RUN: llvm-nm %t2.lto.o | count 0
 
 ; CHECK-NOT: bar
 ; CHECK-NOT: foo
Index: lld/test/ELF/assignment-archive.s
===================================================================
--- lld/test/ELF/assignment-archive.s
+++ lld/test/ELF/assignment-archive.s
@@ -7,6 +7,7 @@
 # RUN: echo "SECTIONS { foo = 1; }" > %t1.script
 # RUN: ld.lld -o %t1.exe --script %t1.script %tar.a %t.o
 # RUN: llvm-readobj --symbols %t1.exe | FileCheck %s
+# CHECK:     Symbols [
 # CHECK-NOT: bar
 # CHECK:     foo
 # CHECK-NOT: bar
Index: lld/test/COFF/start-lib.ll
===================================================================
--- lld/test/COFF/start-lib.ll
+++ lld/test/COFF/start-lib.ll
@@ -22,9 +22,9 @@
 ; RUN: lld-link -out:%t2.exe -entry:main -opt:noref -lldmap:%t2.thinlto.map \
 ; RUN:     %t.bc -start-lib %t1.bc -end-lib %t2.bc
 ; RUN: FileCheck --check-prefix=TEST2 %s < %t2.thinlto.map
-; TEST2-NOT: Name: foo
-; TEST2: bar
-; TEST2-NOT: Name: foo
+; TEST2-NOT: {{ }}foo{{$}}
+; TEST2: {{ }}bar{{$}}
+; TEST2-NOT: {{ }}foo{{$}}
 ;
 ; RUN: lld-link -out:%t3.exe -entry:main -opt:noref -lldmap:%t3.map \
 ; RUN:     %t.obj -start-lib %t1.obj %t2.obj
@@ -32,8 +32,8 @@
 ; RUN: lld-link -out:%t3.exe -entry:main -opt:noref -lldmap:%t3.thinlto.map \
 ; RUN:     %t.bc -start-lib %t1.bc %t2.bc
 ; RUN: FileCheck --check-prefix=TEST3 %s < %t3.thinlto.map
-; TEST3-NOT: foo
-; TEST3-NOT: bar
+; TEST3-NOT: {{ }}foo{{$}}
+; TEST3-NOT: {{ }}bar{{$}}
 
 target datalayout = "e-m:w-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-pc-windows-msvc"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72360.247920.patch
Type: text/x-patch
Size: 2418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200303/80aed640/attachment.bin>


More information about the llvm-commits mailing list