[PATCH] D75375: [MCDwarf] Generate DWARF v5 .debug_rnglists for assembly files

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 08:53:04 PST 2020


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/MC/MCDwarf.cpp:1186
   MCSymbol *InfoSectionSymbol = nullptr;
-  MCSymbol *RangesSectionSymbol = nullptr;
+  MCSymbol *RangesStartSymbol = nullptr;
 
----------------
MaskRay wrote:
> probinson wrote:
> > This seems like a gratuitous name change.  There is only one range list, and it has its own section, so the old name seems fine.
> For .debug_rnglists, It is no longer at the start of the section, so the old name is not appropriate.
Ah, right, I'd forgotten it points to the table not the header, in v5.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75375/new/

https://reviews.llvm.org/D75375





More information about the llvm-commits mailing list