[PATCH] D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks.

Marcel Koester via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 04:35:21 PST 2020


dfki-mako added a subscriber: herhut.
dfki-mako added a comment.

@herhut Regarding your example that one block is in a nested region of the second block: you are right that you will not get the nearest common dominator in this case. In order to add support for these cases, we will have to check whether one region is nested into the other one. May we use the 'isProperAncestor' function to check whether a is nested into b or vice versa?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75507/new/

https://reviews.llvm.org/D75507





More information about the llvm-commits mailing list