[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Tue Mar 3 04:11:20 PST 2020

ikudrin added inline comments.

================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.def:830
+// DWARF v5 Macro header flags
+HANDLE_MACRO_FLAGS(0x02, OFFSET_SIZE_32_LINE_TABLE_PRESENT)
+HANDLE_MACRO_FLAGS(0x04, OPCODE_OPERANDS_TABLE)
----------------
SouraVX wrote:
> ikudrin wrote:
> > There is no such flag in the DWARF standard.
> flags (ubyte) -- The bits of the flags field are interpreted as a set of flags
> 2nd bit `1` and 1st bit `0` combination implies, line table present and DWARF32 respectively.
> Are you suggesting to completely remove these Macro based flags and use raw values ?
The definitions in this file (`Dwarf.def`) have to follow the definitions in the standard as close as possible. Some helpers might have been added to `BinaryFormat/Dwarf.h`, but in this simple case, they are probably unnecessary.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086