[PATCH] D75511: [APFloat] Remove neg in favour of unary operator-

[Jay Foad via Phabricator via llvm-commits]

foad created this revision.
foad added reviewers: ekatz, spatel, jfb, tlively, craig.topper, RKSimon, nikic, scanon.
Herald added subscribers: llvm-commits, dexonsmith.
Herald added a project: LLVM.
foad added a parent revision: D75236: [APFloat] Overload unary operator-.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75511

Files:
  llvm/include/llvm/ADT/APFloat.h
  llvm/unittests/ADT/APFloatTest.cpp


Index: llvm/unittests/ADT/APFloatTest.cpp
===================================================================
--- llvm/unittests/ADT/APFloatTest.cpp
+++ llvm/unittests/ADT/APFloatTest.cpp
@@ -2980,17 +2980,6 @@
   APFloat QNaN = APFloat::getNaN(APFloat::IEEEsingle(), false);
   APFloat NegQNaN = APFloat::getNaN(APFloat::IEEEsingle(), true);
 
-  EXPECT_TRUE(NegOne.bitwiseIsEqual(neg(One)));
-  EXPECT_TRUE(One.bitwiseIsEqual(neg(NegOne)));
-  EXPECT_TRUE(NegZero.bitwiseIsEqual(neg(Zero)));
-  EXPECT_TRUE(Zero.bitwiseIsEqual(neg(NegZero)));
-  EXPECT_TRUE(NegInf.bitwiseIsEqual(neg(Inf)));
-  EXPECT_TRUE(Inf.bitwiseIsEqual(neg(NegInf)));
-  EXPECT_TRUE(NegInf.bitwiseIsEqual(neg(Inf)));
-  EXPECT_TRUE(Inf.bitwiseIsEqual(neg(NegInf)));
-  EXPECT_TRUE(NegQNaN.bitwiseIsEqual(neg(QNaN)));
-  EXPECT_TRUE(QNaN.bitwiseIsEqual(neg(NegQNaN)));
-
   EXPECT_TRUE(NegOne.bitwiseIsEqual(-One));
   EXPECT_TRUE(One.bitwiseIsEqual(-NegOne));
   EXPECT_TRUE(NegZero.bitwiseIsEqual(-Zero));
Index: llvm/include/llvm/ADT/APFloat.h
===================================================================
--- llvm/include/llvm/ADT/APFloat.h
+++ llvm/include/llvm/ADT/APFloat.h
@@ -1243,12 +1243,6 @@
   return X;
 }
 
-/// Returns the negated value of the argument.
-inline APFloat neg(APFloat X) {
-  X.changeSign();
-  return X;
-}
-
 /// Implements IEEE minNum semantics. Returns the smaller of the 2 arguments if
 /// both are not NaN. If either argument is a NaN, returns the other argument.
 LLVM_READONLY


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75511.247843.patch
Type: text/x-patch
Size: 1496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200303/4d29b07d/attachment.bin>