[PATCH] D75507: [mlir] Extended Dominance analysis with a function to find the nearest common dominator of two given blocks.

[Stephan Herhut via Phabricator via llvm-commits]

herhut added inline comments.


================
Comment at: mlir/lib/Analysis/Dominance.cpp:46
+  Region *regionB = b->getParent();
+  if (regionA != regionB) {
+    // Get parent operations and check whether they exist and belong to blocks.
----------------
What about the case where one block is in an ancestor region of the other block. Something like

```
bb0^:
  "some.op"() {
    bb1^:
      // some code
  }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75507/new/

https://reviews.llvm.org/D75507