[PATCH] D75471: [AlignmentFromAssumptions] Fix a SCEV assertion resulting from address space differences.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I think this is generally fine, except the test case changes noted below.

FWIW, this pass will be deleted (hopefully soon).



================
Comment at: llvm/test/Transforms/AlignmentFromAssumptions/amdgpu-crash.ll:3
+; RUN: opt < %s -alignment-from-assumptions -S | FileCheck %s
+; RUN: opt < %s -passes=alignment-from-assumptions -S | FileCheck %s
+
----------------
If you want to test for "non-crash", remove the FileCheck. However, I think you want to test that the generated expression is actually as expected instead.


================
Comment at: llvm/test/Transforms/AlignmentFromAssumptions/amdgpu-crash.ll:47
+!4 = distinct !{!4, !5, !"_ZN42_$LT$str$u20$as$u20$core..fmt..Display$GT$3fmt17h4b7a4f3a0a4d2185E: %self.0"}
+!5 = distinct !{!5, !"_ZN42_$LT$str$u20$as$u20$core..fmt..Display$GT$3fmt17h4b7a4f3a0a4d2185E"}
----------------
Please remove all these attributes and metadata notes, etc., none of it should be needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75471/new/

https://reviews.llvm.org/D75471