[PATCH] D75462: [mem2reg] Enhance to ignore @llvm.assume(icmp ne null) uses.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 19:03:25 PST 2020


jdoerfert added subscribers: Tyker, lebedev.ri, jdoerfert.
jdoerfert requested changes to this revision.
jdoerfert added reviewers: lebedev.ri, fhahn, Tyker, jdoerfert.
jdoerfert added a comment.

While I see how this is generally useful, I fear the implementation goes in the wrong direction.
What I mean is that we are moving away from instruction-based encodings for assume, see for example D74209 <https://reviews.llvm.org/D74209>.
What we need here is basically D73832 <https://reviews.llvm.org/D73832>.

@Tyker @lebedev.ri Maybe lifetime markers are the second use case for the "drop users" interface (D73404 <https://reviews.llvm.org/D73404>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75462/new/

https://reviews.llvm.org/D75462





More information about the llvm-commits mailing list