[PATCH] D72892: [MC][ARM] Resolve some pcrel fixups at assembly time

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 18:33:40 PST 2020


MaskRay added subscribers: ostannard, manojgupta, efriedma.
MaskRay added a comment.

+ at ostannard @efriedma

Given the poor support of these relocations in GNU as, do we still need to produce relocations?

Another FreeBSD developer told me that I should persist and @strejda may change their mind to fix the FreeBSD code.

I am just concerned with the complexity in D75039 <https://reviews.llvm.org/D75039> and D75349 <https://reviews.llvm.org/D75349>. I should mention that so far Android, Chrome and ChromeOS (@nickdesaulniers @manojgupta for visibility) are good. If they find any project that uses such relocation types, I will ask them to avoid adr/ldr referencing a STB_GLOBAL symbol because the assembler portability isn't that great anyway, and it is not bad to avoid constructs involving a dark side of the linker.

If we decide to not support such short range relocation types, we can emit a friendly error message for LLVM 11, telling the user to use a local alias. My current feeling is that 0.001% code might accidentally use them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72892/new/

https://reviews.llvm.org/D72892





More information about the llvm-commits mailing list