[PATCH] D74688: AMDGPU/GlobalISel: Support llvm.trap and llvm.debugtrap intrinsics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3606
+    MachineRegisterInfo &MRI = *B.getMRI();
+    Register SGPR01(AMDGPU::SGPR0_SGPR1);
+    Register LiveIn = getLiveInRegister(B, MRI, SGPR01, LLT::scalar(64),
----------------
I would just use the literal register value below rather than have a variable for it. At least make this a const Register


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3607
+    Register SGPR01(AMDGPU::SGPR0_SGPR1);
+    Register LiveIn = getLiveInRegister(B, MRI, SGPR01, LLT::scalar(64),
+                                        /*InsertLiveInCopy=*/false);
----------------
The type here should really be LLT::pointer(CONSTANT_ADDRESS, 64)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74688/new/

https://reviews.llvm.org/D74688