[PATCH] D75475: AMDGPU: Fix computation for getOccupancyWithLocalMemSize
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 12:03:55 PST 2020
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:361
+ // FIXME: Needs to be a multiple of the group size?
+ //MaxWaves = MaxGroupNumWaves * (MaxWaves / MaxGroupNumWaves);
+
----------------
Yes, we cannot split a group. I think it is better to uncomment this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75475/new/
https://reviews.llvm.org/D75475
More information about the llvm-commits
mailing list