[PATCH] D75266: SROA: Don't drop atomic load/store alignments (PR45010)

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 10:41:28 PST 2020


jfb added a comment.

In D75266#1900542 <https://reviews.llvm.org/D75266#1900542>, @hans wrote:

> In D75266#1898238 <https://reviews.llvm.org/D75266#1898238>, @jfb wrote:
>
> > I meant compare and exchange, as well as RMW.
>
>
> It doesn't look like SROA handles cmpxchg or atomicrmw instructions.


I know, but if it grows that capability then the author will thank you for adding a test that prevents them from regressing correctness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75266/new/

https://reviews.llvm.org/D75266





More information about the llvm-commits mailing list