[PATCH] D74755: [llvm-objcopy] Attribute an empty section to a segment ending at its address

Mon Mar 2 09:30:18 PST 2020

MaskRay added a comment.

In D74755#1900457 <https://reviews.llvm.org/D74755#1900457>, @jhenderson wrote:

> FYI, I'm not ignoring you here, I just want to spend some significant time trying to understand the exact implications of the behaviour change before responding further. Unfortunately, with my current workload, I haven't been able to do that yet.

No hurry! The logic (attributing sections to segments) is intricate, and part of the logic will be shared with obj2yaml (dumping program headers). We should be cautious here.

(I thought about several scenarios that may be similar to your use case, and I can't break default ELFWriter/--only-keep-debug output. If you have a use case that indeed needs to flatten Section::ParentSegment, I will be happy to help in the future.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74755/new/

https://reviews.llvm.org/D74755