[PATCH] D75339: [debuginfo-tests][dexter] Add --builder gcc support for POSIX

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 07:53:23 PST 2020


jmorse added reviewers: TWeaver, StephenTozer.
jmorse added a comment.

Would it not be possible to override handle_options in the tool class, put the logic from _verify_options there (raising an Error if there's a problem), and then call `super(Tool,self).handle_options()` if there's no error? This would avoid the need to add a new method / code path.

Otherwise, adding a gcc builder sounds great!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75339/new/

https://reviews.llvm.org/D75339





More information about the llvm-commits mailing list