[PATCH] D75290: [SystemZ] Also accept ISD::USUBO in shouldFormOverflowOp()

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 05:52:08 PST 2020


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

I see.   I still agree it is preferable to only generate the overflow ops for types where they will be legal.

It also makes sense to still have the test case to something valid by using an explicit overflow op.

So overall, the patch LGTM.  Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75290/new/

https://reviews.llvm.org/D75290





More information about the llvm-commits mailing list