[PATCH] D74176: [CMake] Link against ZLIB::ZLIB

Mon Mar 2 02:18:34 PST 2020

hans added a comment.

In D74176#1900473 <https://reviews.llvm.org/D74176#1900473>, @hans wrote:

> In D74176#1899793 <https://reviews.llvm.org/D74176#1899793>, @rnk wrote:
>
> >   and rGe441a584f3f7d743ab77031a47d9ad60ee56b53d.
>
>
> I've pushed that to 10.x in f5fd8a37c18439102eb30c85dadac68c260a1a0d <https://reviews.llvm.org/rGf5fd8a37c18439102eb30c85dadac68c260a1a0d>, as we had also merged the patch it's fixing.
>
> I'll look at doing the same thing for zlib. Also, cmake is horrible.

Nice, I see rnk already did this in 1079c68aa0fdb14d270a31c0df49a2afc5ed2485 <https://reviews.llvm.org/rG1079c68aa0fdb14d270a31c0df49a2afc5ed2485>.

So hopefully we're all good? Please let me know otherwise.

I've pushed these three changes to 10.x for PR44780:

  D74106 50a6d3a6486d  "[CMake] Use PUBLIC link mode for static libraries"
  D74176 2181bf40d871  "[CMake] Link against ZLIB::ZLIB"
         1079c68aa0fd  "Attempt to fix ZLIB CMake logic on Windows"

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74176/new/

https://reviews.llvm.org/D74176