[PATCH] D75428: [MC][ARM] add implicit immediate form for ldrsbt/ldrht/ldrsht

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 02:04:41 PST 2020


psmith added reviewers: ostannard, eli.friedman.
psmith added a comment.

Adding some more reviewers. I'm not aware of any hard and fast rule as to when to use a new instruction or an alias, I think it is a case by case decision, although people more familiar with tablegen may know otherwise.
I'd prefer a solution where the disassembly of `ldrsht r5, [r6]` is either `ldrsht r5, [r6]` or  `ldrsht r5, [r6], #0`. `ldrsht r5, [r6], #-0` is legal but not really canonical, maybe always set the U bit (23) to make the immediate positive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75428/new/

https://reviews.llvm.org/D75428





More information about the llvm-commits mailing list