[PATCH] D75342: [obj2yaml] - Teach tool to dump program headers.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 01:55:03 PST 2020
jhenderson added a comment.
In D75342#1900331 <https://reviews.llvm.org/D75342#1900331>, @MaskRay wrote:
> The dumpProgramHeaders() logic is similar to `llvm-objcopy/ELF/Object.cpp:sectionWithSegment`. It also reminds me of D74755 <https://reviews.llvm.org/D74755>... The attribution of an empty section on the boundary between two segments will not affect obj2yaml correctness.
Yes, I think in obj2yaml, it doesn't matter which segments a section is within, because the output should have the segments at exactly the same place as the input. There should be no moving of segments in obj2yaml, in my opinion, as it should provide as faithful a representation as possbile of the original input.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75342/new/
https://reviews.llvm.org/D75342
More information about the llvm-commits
mailing list