[PATCH] D75404: [X86] Not track size of the boudaryalign fragment during the layout
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 1 19:13:02 PST 2020
skan added a comment.
In D75404#1900225 <https://reviews.llvm.org/D75404#1900225>, @MaskRay wrote:
> > Thanks for deleting the Size member variable. It can avoid some cache invalidation problems. LGTM, but please wait for another pair of eyes.
>
>
>
> > Closed by commit rG2ac19feb1571 <https://reviews.llvm.org/rG2ac19feb1571960b8e1479a451b45ab56da7034e>: [X86] Not track size of the boudaryalign fragment during the layout (authored by skan). ยท Explain Why
>
> For this case, it is likely that @reames will want to review the change, so I provided a qualified approval. From D71916 <https://reviews.llvm.org/D71916> "LGTM - How a Patch Is Accepted":
Thanks for pointing out. I missed the comments "easily during the layout process." and "wait for another pair of eyes" unintentionally.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75404/new/
https://reviews.llvm.org/D75404
More information about the llvm-commits
mailing list