[PATCH] D75404: [X86] Not track size of the boudaryalign fragment during the layout

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 1 17:08:30 PST 2020


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Thanks for deleting the `Size` member variable. It can avoid some cache invalidation problems. LGTM, but please wait for another pair of eyes.



================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:445
   // If the branch is emitted into a MCRelaxableFragment, we can determine the
-  // size of the branch easily in MCAssembler::relaxBoundaryAlign. When the
+  // size of the branch easily in during the process of layout. When the
   // branch is fused, the fused branch(macro fusion pair) must be emitted into
----------------
easily during the layout process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75404/new/

https://reviews.llvm.org/D75404





More information about the llvm-commits mailing list