[PATCH] D74486: [PowerPC][Future] Add initial support for PC Relative addressing for constant pool loads

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2541
 
+bool PPCTargetLowering::SelectAddressPCRel(SDValue N, SDValue &Base) const {
+  ConstantPoolSDNode *ConstPoolNode =
----------------
I think it would be good if we had doxygen /// comments for this. 


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:375
+  // If the MATpcreladdr node is not caught by any other pattern it should be
+  // caught here and turned into a paddi instruction to meterialize the address.
+  def : Pat<(MATpcreladdr pcreladdr:$cp), (PADDI8pc 0, $cp)>;
----------------
s/meterialize/materialize 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74486/new/

https://reviews.llvm.org/D74486